Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove correlated column sort items #9435

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

fix the issue that order by correlated column panic in the executor

What is changed and how it works?

remove correlated column from sort items in sort/topn push down after column substitution.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Feb 25, 2019
@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member Author

/run-integration-common-test

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 25, 2019
@codecov-io
Copy link

Codecov Report

Merging #9435 into master will decrease coverage by 0.15%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9435      +/-   ##
==========================================
- Coverage   67.19%   67.04%   -0.16%     
==========================================
  Files         373      373              
  Lines       78386    78386              
==========================================
- Hits        52672    52553     -119     
- Misses      20996    21131     +135     
+ Partials     4718     4702      -16
Impacted Files Coverage Δ
planner/core/rule_topn_push_down.go 92.68% <50%> (ø) ⬆️
util/filesort/filesort.go 41.06% <0%> (-35.43%) ⬇️
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
ddl/delete_range.go 77.77% <0%> (-1.59%) ⬇️
store/tikv/lock_resolver.go 41.7% <0%> (-0.95%) ⬇️
executor/join.go 79.42% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3842a...ce2bf35. Read the comment docs.

@zz-jason zz-jason merged commit f105b71 into pingcap:master Feb 25, 2019
@zz-jason zz-jason deleted the bugfix/order-by-correlated-column branch February 25, 2019 06:49
zz-jason added a commit to zz-jason/tidb that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants