-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: remove correlated column sort items #9435
planner: remove correlated column sort items #9435
Conversation
/run-all-tests |
/run-integration-common-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #9435 +/- ##
==========================================
- Coverage 67.19% 67.04% -0.16%
==========================================
Files 373 373
Lines 78386 78386
==========================================
- Hits 52672 52553 -119
- Misses 20996 21131 +135
+ Partials 4718 4702 -16
Continue to review full report at Codecov.
|
What problem does this PR solve?
fix the issue that order by correlated column panic in the executor
What is changed and how it works?
remove correlated column from sort items in sort/topn push down after column substitution.
Check List
Tests
Related changes