-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: add builtin json_array_append #9609
Conversation
Thank you for your contribution! It looks like the CI is broken on |
Codecov Report
@@ Coverage Diff @@
## master #9609 +/- ##
===============================================
+ Coverage 67.3893% 67.398% +0.0087%
===============================================
Files 377 377
Lines 79385 79434 +49
===============================================
+ Hits 53497 53537 +40
- Misses 21111 21115 +4
- Partials 4777 4782 +5 |
61a89d5
to
1c3269c
Compare
/run-all-tests |
/run-all-tests |
/run-all-tests |
/run-all-tests |
75a5aa8
to
09026d7
Compare
09026d7
to
2c7506c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
a part of #7546
What is changed and how it works?
o. if
path
isnull
, do nothing and return null without checking other errorso. if
path
is illegal (invalid or contains wildcard), throw erroro. if json object at
path
is not an array, warp it with a array.o. append the obj to that array with
json.MergeBinary
o. call
Modify
to commit changeOriginal MySQL document:
Observed behavior on MySQL 8.0:
Check List
Tests
Code changes