-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add window function PERCENT_RANK #9671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #9671 +/- ##
================================================
- Coverage 67.4153% 67.3955% -0.0198%
================================================
Files 376 377 +1
Lines 79252 79345 +93
================================================
+ Hits 53428 53475 +47
- Misses 21052 21099 +47
+ Partials 4772 4771 -1 |
Co-Authored-By: winoros <winoros@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
Add window function support for
PERCENT_RANK
. Part of #9499What is changed and how it works?
Following the calculation formula
percent_rank = (rank - 1) / (rows_in_set - 1)
Check List
Tests