Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add window function PERCENT_RANK #9671

Merged
merged 3 commits into from
Mar 13, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Mar 12, 2019

What problem does this PR solve?

Add window function support for PERCENT_RANK. Part of #9499

What is changed and how it works?

Following the calculation formula percent_rank = (rank - 1) / (rows_in_set - 1)

Check List

Tests

  • Unit test

@alivxxx alivxxx mentioned this pull request Mar 12, 2019
11 tasks
@alivxxx alivxxx added sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement. labels Mar 12, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2019
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #9671 into master will decrease coverage by 0.0197%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master      #9671        +/-   ##
================================================
- Coverage   67.4153%   67.3955%   -0.0198%     
================================================
  Files           376        377         +1     
  Lines         79252      79345        +93     
================================================
+ Hits          53428      53475        +47     
- Misses        21052      21099        +47     
+ Partials       4772       4771         -1

Co-Authored-By: winoros <winoros@gmail.com>
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 13, 2019
@zz-jason
Copy link
Member

/run-all-tests

@winoros winoros merged commit f5a4dd9 into pingcap:master Mar 13, 2019
@winoros winoros deleted the window-percent-rank branch March 13, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants