Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support window function lead and lag #9672

Merged
merged 6 commits into from
Mar 14, 2019
Merged

executor: support window function lead and lag #9672

merged 6 commits into from
Mar 14, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Mar 12, 2019

What problem does this PR solve?

Support window function lead and lag.
Refer https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lead and https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag

For #9499

What is changed and how it works?

Implement the lead and lag under the aggfunc interface.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Mar 12, 2019
@alivxxx alivxxx mentioned this pull request Mar 12, 2019
Closed
11 tasks
@codecov
Copy link

codecov bot commented Mar 12, 2019 •
edited
Loading

Codecov Report

Merging #9672 into master will increase coverage by 0.0448%.
The diff coverage is 4.054%.

@@               Coverage Diff                @@
##             master      #9672        +/-   ##
================================================
+ Coverage   67.3717%   67.4166%   +0.0448%     
================================================
  Files           377        378         +1     
  Lines         79465      79872       +407     
================================================
+ Hits          53537      53847       +310     
- Misses        21140      21222        +82     
- Partials       4788       4803        +15

qw4990
qw4990 reviewed Mar 12, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 14, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Mar 14, 2019

/run-all-tests

@alivxxx alivxxx merged commit 4422a23 into pingcap:master Mar 14, 2019
@alivxxx alivxxx deleted the leadlag branch March 14, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@qw4990 qw4990 qw4990 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @zz-jason @qw4990 @winoros