Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: remove wait time after canceling a job #9768

Merged
merged 3 commits into from
Mar 19, 2019
Merged

ddl: remove wait time after canceling a job #9768

merged 3 commits into from
Mar 19, 2019

Conversation

zimulala
Copy link
Contributor

cherry-pick #9648 to v2.1

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@zimulala
Copy link
Contributor Author

PTAL @crazycs520 @xiekeyi98

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

xiekeyi98
xiekeyi98 reviewed Mar 19, 2019
View reviewed changes
Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST LGTM.

ddl/db_integration_test.go Outdated Show resolved Hide resolved
@zimulala
Copy link
Contributor Author

PTAL @xiekeyi98

crazycs520
crazycs520 reviewed Mar 19, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2019
xiekeyi98
xiekeyi98 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 346009f into pingcap:release-2.1 Mar 19, 2019
@zimulala zimulala deleted the zimuxia/ddl-save-time branch March 19, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@xiekeyi98 xiekeyi98 xiekeyi98 approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zimulala @xiekeyi98 @crazycs520 @zz-jason