config: fix config toml file check-mb4-value-in-utf8 problem.
#9802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
What problem? |
|
@xiekeyi98 Sorry for my fuzzy definition in PR description. PTAL again. |
|
/run-unit-test |
xiekeyi98
added
status/LGT1
Codecov Report
@@ Coverage Diff @@
## master #9802 +/- ##
================================================
+ Coverage 67.2333% 67.2421% +0.0087%
================================================
Files 381 381
Lines 79874 79874
================================================
+ Hits 53702 53709 +7
+ Misses 21387 21381 -6
+ Partials 4785 4784 -1 |
|
LGTM |
shenli
added
status/LGT2
shenli
approved these changes
Mar 19, 2019
crazycs520
changed the title
check-mb4-value-in-utf8 problem.
|
@crazycs520 Please pick this commit to v2.1. |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Mar 21, 2019
shenli
pushed a commit
that referenced
this pull request
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently in
config/config.toml.examplefile, variablecheck-mb4-value-in-utf8is belong to the[binlog]scope, but It should be the global scope correspond to theConfigstruct.What is changed and how it works?
Move
check-mb4-value-in-utf8to global scope inconfig/config.toml.examplefile.Check List
Tests