Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix utf8 charset upgrade compatibility #9820
*: fix utf8 charset upgrade compatibility #9820
Changes from 15 commits
3924856
d96be67
3a77bc6
16494b2
c8e5b9d
15c43af
18125dc
40c68dc
e4f71a1
1ed6ef6
655fc6b
adc67a2
786c6e8
7c1b4f4
a612ab9
b0512cf
99de30a
e757f21
62d49b8
d6b6280
57f22e6
2d226d1
e520900
44912c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If execute
alter table t add column c varchar(10)
here, the column will beUTF8
, because the table charset actually isUTF8
,tidb_treat_old_version_utf8_as_utf8mb4
currently only take effect ininsert
andshow create table
. Was this expected in the end? @winkyao