server: ConnectionEvent error from plugins should not make TiDB exit #9889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9889 +/- ##
================================================
- Coverage 77.2034% 67.1154% -10.088%
================================================
Files 405 385 -20
Lines 81635 80588 -1047
================================================
- Hits 63025 54087 -8938
- Misses 13939 21652 +7713
- Partials 4671 4849 +178 |
|
PTAL @jackysp |
|
/run-all-tests |
|
It looks like the error is completely discarded. Should it be logged first? |
|
It's already logged here https://github.com/pingcap/tidb/pull/9889/files#diff-91bbeda7eb98a7adc57b9e47e2cf5c2bR346 |
|
oh, good! It would be best to log the error where it is being dropped though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When I am testing whitelist plugin, I find that whitelist check fail makes tidb exit. That completely unreasonable.
What is changed and how it works?
ConnectionEventerror from plugins should not make TiDB exitCheck List
Tests
@lysu