Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, executor: support SQL show pump/drainer status #9896

Merged
merged 2 commits into from
Mar 26, 2019
Merged

planner, executor: support SQL show pump/drainer status #9896

merged 2 commits into from
Mar 26, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Mar 26, 2019 •
edited
Loading

What problem does this PR solve?

support SQL show pump/drainer status

What is changed and how it works?

  1. git cherry pick planner, executor: support SQL show pump/drainer status #9456
    and resolve conflict
  2. update parser to latest release2.1 pingcap/parser@750ee1d

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release note

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

1 similar comment
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

XuHuaiyu
XuHuaiyu previously approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu dismissed their stale review March 26, 2019 07:50

only 1 LGTM

zimulala
zimulala reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit fbab0fd into pingcap:release-2.1 Mar 26, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/cherry-pick-show-pump-drainer branch March 26, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

Assignees
No one assigned
Labels
component/binlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WangXiangUSTC @zimulala @XuHuaiyu @caohe