Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: using pingcap/log and unify the log format( #9659) #9955

Merged
merged 3 commits into from
Apr 3, 2019
Merged

ddl: using pingcap/log and unify the log format( #9659) #9955

merged 3 commits into from
Apr 3, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #9659

xiekeyi98
xiekeyi98 reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@qw4990 qw4990 mentioned this pull request Apr 1, 2019
Merged
@bb7133
Copy link
Member

bb7133 commented Apr 1, 2019

Please fix the conflict

@xiekeyi98 xiekeyi98 mentioned this pull request Apr 2, 2019
Merged
zimulala
zimulala reviewed Apr 3, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 3, 2019
bb7133
bb7133 approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@crazycs520 crazycs520 added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Apr 3, 2019
@winkyao winkyao merged commit b7b8acf into pingcap:release-2.1 Apr 3, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiekeyi98 xiekeyi98 xiekeyi98 left review comments

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crazycs520 @bb7133 @zimulala @xiekeyi98 @shenli @winkyao @you06