Skip to content

Commit

Permalink
Log warning instead of throw exception when meets big region
Browse files Browse the repository at this point in the history
  • Loading branch information
JaySon-Huang committed Nov 1, 2019
1 parent e643a21 commit d521a37
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions dbms/src/Storages/Transaction/RegionPersister.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ void RegionPersister::computeRegionWriteBuffer(const Region & region, RegionCach
std::tie(region_size, applied_index) = region.serialize(buffer);
if (unlikely(region_size > static_cast<size_t>(std::numeric_limits<UInt32>::max())))
{
LOG_ERROR(&Logger::get("RegionPersister"),
region.toString() << " with data info: " << region.dataInfo() << ", serialized size " << region_size
<< " is too big to persist");
throw Exception("Region is too big to persist", ErrorCodes::LOGICAL_ERROR);
LOG_WARNING(&Logger::get("RegionPersister"),
"Persisting big region: " << region.toString() << " with data info: " << region.dataInfo() << ", serialized size "
<< region_size);
//throw Exception("Region is too big to persist", ErrorCodes::LOGICAL_ERROR);
}
}

Expand Down

0 comments on commit d521a37

Please sign in to comment.