Skip to content

Commit

Permalink
fix conflict
Browse files Browse the repository at this point in the history
Signed-off-by: gengliqi <gengliqiii@gmail.com>
  • Loading branch information
gengliqi committed Jul 21, 2022
1 parent a36e6b5 commit f9eea05
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,18 +160,8 @@ void ParallelAggregatingBlockInputStream::Handler::onFinish()
void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_ptr & exception, size_t thread_num)
{
parent.exceptions[thread_num] = exception;
<<<<<<< HEAD
/// can not cancel parent inputStream or the exception might be lost
if (!parent.executed)
parent.processor.cancel(false);
=======
Int32 old_value = -1;
parent.first_exception_index.compare_exchange_strong(old_value, static_cast<Int32>(thread_num), std::memory_order_seq_cst, std::memory_order_relaxed);

if (!parent.executed)
/// use cancel instead of kill to avoid too many useless error message
parent.cancel(false);
>>>>>>> 7b280755ba (fix a panic issue in parallel agg when exception is thrown (#5433))
}


Expand Down

0 comments on commit f9eea05

Please sign in to comment.