Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-348] Optimize Some Modules #119

Closed
wants to merge 1 commit into from
Closed

[FLASH-348] Optimize Some Modules #119

wants to merge 1 commit into from

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Jul 20, 2019

  • optimize TiKVRange::getRangeHandle

  • add void TxnMergeTreeBlockOutputStream::write(Block && block)

  • add log for cost of region cache scan and compute block

  • optimize decodeTiKVKeyFull

@solotzg
Copy link
Contributor Author

solotzg commented Jul 22, 2019

/run-integration-tests

@@ -331,7 +346,6 @@ void RegionTable::applySnapshotRegions(const RegionMap & region_map)
if (cache_bytes)
internal_region.updated = true;
}
doShrinkRegionRange(*region);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we dont need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function will only be called during initiation, there will not be any redundancy.

Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comment should be addressed at #121

@solotzg
Copy link
Contributor Author

solotzg commented Jul 23, 2019

All changes have been merged in #121

@solotzg solotzg closed this Jul 23, 2019
@solotzg solotzg deleted the FLASH-348 branch July 23, 2019 06:39
guo-shaoge added a commit to guo-shaoge/tiflash that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants