Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log redact for client-c (#1306) #1309

Merged

Conversation

ti-srebot
Copy link
Collaborator

cherry-pick #1306 to release-5.0-rc


Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: a part of #1277

Problem Summary: Avoid printing user data (client-c resolve lock error) to the logging file.

What is changed and how it works?

Update client-c and set redact flag for client-c

Related changes

  • Need to cherry-pick to the release branch 5.0-rc

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • No release note

JaySon-Huang and others added 2 commits December 24, 2020 16:01
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels Dec 24, 2020
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang added this to the v5.0.0-rc milestone Dec 24, 2020
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanmato1984 zanmato1984 merged commit 89f0ca0 into pingcap:release-5.0-rc Dec 24, 2020
@zanmato1984 zanmato1984 deleted the release-5.0-rc-83bf32550494 branch December 24, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants