Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flash-360] support cyclic rename #137

Merged
merged 142 commits into from
Aug 6, 2019
Merged

[flash-360] support cyclic rename #137

merged 142 commits into from
Aug 6, 2019

Conversation

hanfei1991
Copy link
Member

No description provided.

zanmato1984 and others added 30 commits June 11, 2019 15:07
@zanmato1984
Widen schema syncer with sync all semantic, add background schema syn…
a514e64 
…c service and do init sync on startup
@zanmato1984
Merge branch 'master' into ddl
4a79bb7
@zanmato1984
Finish widen some data types to avoid data rewriting during apply ddl
0eafdd4
@zanmato1984
Merge branch 'master' into ddl
9d69885
@zanmato1984
Add update_timestamp into table info
5b648cc
@zanmato1984
Refine read and flush to be more robust for schema change
647bbbb
@zanmato1984
Fix nullable for overflow check when decode region cache
bf25957
@zanmato1984
Add schema state enum
095ca6c
@zanmato1984
Support column type change in schema syncer
dd50f03
@zanmato1984
Fix comment
363ecc7
@zanmato1984
Add mock functions for TiDB DDL
18ed32e
@zanmato1984
Fix rvalue ref
402132a
@zanmato1984
Fix some bugs in schema syncer and mock tidb
02ad15e
@zanmato1984
Adjust test
fb2b960
@zanmato1984
Add alter test
718d1c0
@zanmato1984
Not do data conversion for alter txn table, as we already stored wide…
463836e 
…n data
@zanmato1984
Fix typo
e86d96a
@zanmato1984
Fix mock tidb reverse type mapping
6988bdb
@zanmato1984
Enhance overflow checking when flushing
7fb48af
@zanmato1984
Enhance alter test
9ad7a1c
@zanmato1984
Refine some code
509ee1c
@zanmato1984
Remove table region mapping when drop table
f26a75e
@zanmato1984
Adjust drop order
261b3d2
@zanmato1984
Print file path in mutable test script when error
47d17fc
@zanmato1984
Fix insert widen data through sql
d409926
@zanmato1984
Fix some txn tests
40379bf
@zanmato1984
Fix widen data write of import statement
ebd897a
@hanfei1991 @zanmato1984
DDL read and update by tikv's meta (#103)
98d09cf 
* DDL read and update by tikv's meta

* add dbg back

* refine test

* address comments
@zanmato1984
Add schema version check before reading
423363a
@zanmato1984
Merge branch 'ddl' into ddl-ruoxi
c6f32a6
zanmato1984
zanmato1984 reviewed Aug 5, 2019
View reviewed changes
dbms/src/Storages/Transaction/TiDBSchemaSyncer.h Outdated
for (const auto & diff : diffs)
{
builder.applyDiff(diff);
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hanfei1991 hanfei1991 changed the base branch from ddl to master August 5, 2019 11:47
@hanfei1991 hanfei1991 changed the title [flash-360][dnm] support cyclic rename [flash-360] support cyclic rename Aug 5, 2019
@hanfei1991 hanfei1991 changed the base branch from master to ddl August 5, 2019 12:04
@hanfei1991 hanfei1991 changed the base branch from ddl to master August 5, 2019 12:43
@hanfei1991
Copy link
Member Author

@zanmato1984 PTAL again

@hanfei1991
Copy link
Member Author

/rebuild

1 similar comment
@hanfei1991
Copy link
Member Author

/rebuild

@hanfei1991
Copy link
Member Author

/run-integrate-tests

@hanfei1991
Copy link
Member Author

/run-integration-tests

zanmato1984
zanmato1984 reviewed Aug 5, 2019
View reviewed changes
dbms/src/Storages/Transaction/SchemaBuilder.cpp Outdated
inline TableName generateTmpTable(const TableName & name) { return TableName(name.first, String(TmpTableNamePrefix) + name.second); }

TableNamePair resolveRename(
SchemaBuilder * builder, TableNameMap & map, TableNameMap::iterator it, TableNameSet & visited, TableNameMap::iterator & cycle_it)
Copy link
Contributor

@zanmato1984 zanmato1984 Aug 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems cycle_it has no effect but confusing people.

zanmato1984
zanmato1984 approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991
Copy link
Member Author

/rebuild

@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991 hanfei1991 merged commit 2f8ee1b into master Aug 6, 2019
@hanfei1991 hanfei1991 deleted the hanfei-ddl/cyclic-rename branch August 6, 2019 05:31
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanfei1991 @zanmato1984 @lidezhu @solotzg