[flash-456] alter for nullable attribute #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
zanmato1984
reviewed
Aug 28, 2019
|
/run-integration-tests |
zanmato1984
reviewed
Aug 29, 2019
| { | ||
| // Overflow detected, fatal if force_decode is true, | ||
| // Null value with non-null type detected, fatal if force_decode is true, | ||
| // as schema being newer and narrow shouldn't happen. |
There was a problem hiding this comment.
newer and narrow -> newer and with invalid null
|
/run-integration-tests |
12 tasks
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 2, 2024
… (pingcap#207) Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we change nullable to not null, we do nothing.
if we change not null to nullable, we write null map files ***.null.bin and ***.null.mrk