[FLASH-298] Import DecodedTiKVKey and TableRowIDMinMax #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerr
reviewed
Sep 3, 2019
| @@ -19,12 +19,13 @@ struct CFKeyHasher | |||
|
|
|||
| struct RegionWriteCFDataTrait | |||
| { | |||
| static const std::string name; | |||
There was a problem hiding this comment.
If my memories are not wrong, we could define static const std::string name = 'foobar' in .h, just work for static vars.
There was a problem hiding this comment.
I've test and this didn't work. std::string need constructor.
There was a problem hiding this comment.
name is a static variables of struct RegionWriteCFDataTrait, if we want to access it out of this struct, we must initialize it out of RegionWriteCFDataTrait.
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DecodedTiKVKey to present decoded tikv key instead of std::string.
Implement TableRowIDMinMax to optimize min/max key for table record.