Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASH-466] improve code coverage #219

Merged
merged 2 commits into from
Sep 6, 2019
Merged

[FLASH-466] improve code coverage #219

merged 2 commits into from
Sep 6, 2019

Conversation

marsishandsome
Copy link
Contributor

@marsishandsome marsishandsome commented Sep 4, 2019 •
edited
Loading

1. improve code coverage

  • Storages/DeltaMerge  69% -> 78.3%
  • Storages/Page            81.1% -> 82.0%

2. fix some bugs

  • bug in dbms/src/Storages/DeltaMerge/HandleFilter.h
  • devide by zero in dbms/src/Storages/DeltaMerge/Segment.cpp

3. remove unused code

  • dbms/src/Storages/DeltaMerge/Chunk.cpp
  • dbms/src/Storages/StorageDeltaMerge.cpp

4. refactor

  • move code to PageUtil.h

@marsishandsome marsishandsome force-pushed the feature/add-ut branch 2 times, most recently from 40dd946 to 4a24876 Compare September 5, 2019 05:17
@marsishandsome
Copy link
Contributor Author

/build

@marsishandsome marsishandsome changed the title [DNM] [FLASH-466] add ut [DNM] [FLASH-466] improve code coverage Sep 5, 2019
@marsishandsome
Copy link
Contributor Author

/run-integration-tests

@marsishandsome marsishandsome changed the title [DNM] [FLASH-466] improve code coverage [FLASH-466] improve code coverage Sep 5, 2019
@marsishandsome
Copy link
Contributor Author

/build

@marsishandsome
Copy link
Contributor Author

/run-integration-tests

JaySon-Huang
JaySon-Huang approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Contributor Author

/run-integration-tests

@marsishandsome marsishandsome merged commit 6f1075b into pingcap:DeltaMergeEngine Sep 6, 2019
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Sep 12, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (pingcap#219)
8053613
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Sep 18, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (pingcap#219)
7ca5ee3
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Sep 23, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (pingcap#219)
8715148
JaySon-Huang pushed a commit that referenced this pull request Sep 26, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (#219)
85fac13
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Oct 17, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (pingcap#219)
89a80a6
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Oct 18, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (pingcap#219)
4f57898
JaySon-Huang pushed a commit that referenced this pull request Oct 22, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (#219)
c33eca3
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Oct 23, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (pingcap#219)
5f0815f
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Oct 30, 2019
@marsishandsome @JaySon-Huang
[FLASH-466] improve code coverage (pingcap#219)
dc5c2f5
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
@marsishandsome @zanmato1984
[FLASH-466] improve code coverage (pingcap#219)
1253216
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
@marsishandsome @zanmato1984
[FLASH-466] improve code coverage (pingcap#219)
b41a5ac
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 5, 2019
@marsishandsome @zanmato1984
[FLASH-466] improve code coverage (pingcap#219)
1b56ed9
@CalvinNeo CalvinNeo mentioned this pull request Nov 11, 2022
Merged
12 tasks
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@CalvinNeo
Disable Parallel Prehandle (pingcap#219)
161c9ef 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsishandsome @JaySon-Huang