Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty value during decode #229

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Add empty value during decode #229

merged 2 commits into from
Sep 10, 2019

Conversation

ilovesoup
Copy link
Contributor

When rows being deleted or other cases that we need a trivial decode to make a valid row, we use this GenDecodeRow code path. This PR is to add support for generating empty JSON field.

Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor

solotzg commented Sep 10, 2019

/run-integretion-tests

@ilovesoup ilovesoup merged commit 0898b27 into master Sep 10, 2019
@solotzg solotzg deleted the add_default_val branch September 10, 2019 11:58
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants