Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash-556] choose learner address by config address hint #284

Merged
merged 11 commits into from
Oct 18, 2019

Conversation

hanfei1991
Copy link
Member

When a region have peers in two tiflash stores, we should try to find out the store with local address. And when a store is down, we try another store , but reload region meta and try last store, which may lead to a forever loop.

@hanfei1991 hanfei1991 requested a review from solotzg October 17, 2019 05:29
@pingcap pingcap deleted a comment from hanfei1991 Oct 18, 2019
@hanfei1991
Copy link
Member Author

/run-integration-tests

@zanmato1984
Copy link
Contributor

/run-integration-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991 hanfei1991 merged commit 7648255 into master Oct 18, 2019
@hanfei1991 hanfei1991 deleted the hanfei-client-c/choose-learners branch October 18, 2019 17:10
CalvinNeo added a commit to CalvinNeo/tiflash that referenced this pull request Sep 23, 2024
…gcap#284)

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: JaySon <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants