Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flash-600] PageStorage GC only remove obsoleted data #297

Merged
merged 5 commits into from
Oct 30, 2019
Merged

[Flash-600] PageStorage GC only remove obsoleted data #297

merged 5 commits into from
Oct 30, 2019

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Oct 29, 2019 •
edited
Loading

  • PageStorage
    • gcRemoveObsoleteFiles -> gcRemoveObsoleteData. Only remove PageFile's data.
    • Another gc for PageFile's meta will be done later(FLASH-530)
  • PageFile now have 3 state
    • Formal: written by PageStorage or generate from GC thread
    • Temp: writing by PageStorage GC thread
    • Legacy: PageStorage GC thread have already removed the data, just left meta for recover
  • WriteBatch && PageEntriesEdit
    • Add a new write type(MOVE_NORMAL_PAGE) to indicate that we only move the normal page to new PageEntry rather than putting new page

    Note that PUT means that we put a new page and need a ref-page with same page id. And MOVE_NORMAL_PAGE means that we move a exist page to a new PageFile.

@JaySon-Huang
Copy link
Contributor Author

/run-integration-tests

@flowbehappy
Copy link
Contributor

LGTM

@JaySon-Huang JaySon-Huang merged this pull request into pingcap:DeltaMergeEngine Oct 30, 2019
@JaySon-Huang JaySon-Huang deleted the FLASH-600 branch October 30, 2019 10:56
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Oct 30, 2019
@JaySon-Huang
[Flash-600] PageStorage GC only remove obsoleted data (pingcap#297)
a02b179 
* Add test case for migrate ref-page to ref-page

* check if ref-page is valid

* only remove PageFile's data

* Add MOVE_NORMAL_PAGE for only move normal page

* enhance utils_get_valid_pages
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
@JaySon-Huang @zanmato1984
[Flash-600] PageStorage GC only remove obsoleted data (pingcap#297)
866b39b 
* Add test case for migrate ref-page to ref-page

* check if ref-page is valid

* only remove PageFile's data

* Add MOVE_NORMAL_PAGE for only move normal page

* enhance utils_get_valid_pages
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
@JaySon-Huang @zanmato1984
[Flash-600] PageStorage GC only remove obsoleted data (pingcap#297)
990c000 
* Add test case for migrate ref-page to ref-page

* check if ref-page is valid

* only remove PageFile's data

* Add MOVE_NORMAL_PAGE for only move normal page

* enhance utils_get_valid_pages
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Nov 5, 2019
@JaySon-Huang @zanmato1984
[Flash-600] PageStorage GC only remove obsoleted data (pingcap#297)
6613c6c 
* Add test case for migrate ref-page to ref-page

* check if ref-page is valid

* only remove PageFile's data

* Add MOVE_NORMAL_PAGE for only move normal page

* enhance utils_get_valid_pages
CalvinNeo pushed a commit to CalvinNeo/tiflash that referenced this pull request Sep 23, 2024
@yongman
proxy: fix shard_ver in preprocess_pending_splits (pingcap#297)
91b4285 
Signed-off-by: yongman <yming0221@gmail.com>
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaySon-Huang @flowbehappy