Resolve hostname in tics config #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanmato1984
reviewed
Nov 1, 2019
| @@ -64,7 +64,7 @@ int64_t IndexReader::getReadIndex() | |||
| for (const auto & learner : learners) | |||
| { | |||
| std::string addr = cache->getStore(bo, learner.store_id()).addr; | |||
| if (addr.size() > 0 && convertAddr(addr) == suggested_ip) | |||
| if (addr.size() > 0 && convertAddr(addr) == convertAddr(suggested_address)) | |||
There was a problem hiding this comment.
There might be a legacy bug: finding target learner only compares IP address, we need to consider port as well to allow multiple instances on same host.
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
12 tasks
12 tasks
CalvinNeo
pushed a commit
to CalvinNeo/tiflash
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.