FLASH-674: check region version in executeTS #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanmato1984
changed the title
|
/run-integration-tests |
| @@ -262,11 +262,12 @@ void InterpreterDAG::executeTS(const tipb::TableScan & ts, Pipeline & pipeline) | |||
| info.version = dag.getRegionVersion(); | |||
| info.conf_version = dag.getRegionConfVersion(); | |||
| auto current_region = context.getTMTContext().getKVStore()->getRegion(info.region_id); | |||
| if (!current_region) | |||
| if (!current_region || current_region->version() != dag.getRegionVersion() || current_region->confVer() != dag.getRegionConfVersion()) | |||
There was a problem hiding this comment.
Maybe we should add one more check:
if (current_region->isPendingRemove())
// throw RegionException(..., RegionException::RegionReadStatus::PENDING_REMOVE);
There was a problem hiding this comment.
Yes, region status should also be checked here
This was referenced May 6, 2023
12 tasks
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Dec 3, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
CalvinNeo
added a commit
to CalvinNeo/tiflash
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.