Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-622] DMFile implementation #327

Merged
merged 8 commits into from
Nov 27, 2019
Merged

[FLASH-622] DMFile implementation #327

merged 8 commits into from
Nov 27, 2019

Conversation

flowbehappy
Copy link
Contributor

  • Import DMFile
  • Temporary disable test cases of DDL and Segment merge

dbms/src/Storages/DeltaMerge/Chunk.h Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/DeltaMergeStore.h Outdated Show resolved Hide resolved
@@ -0,0 +1,65 @@
#pragma once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can move to Storages/DeltaMerge/File

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep it, more information could add into later.


size_t StableValueSpace::getBytes()
{
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe later, we don't use bytes for now.

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor

/run-integration-tests

@JaySon-Huang
Copy link
Contributor

I rebase and use ReorganizeBlockInputStream to tidy up the boundary of chunks. #330
cc @flowbehappy

@flowbehappy
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@JaySon-Huang
Copy link
Contributor

/run-integration-tests

@flowbehappy flowbehappy merged commit 885bc3f into pingcap:DeltaMergeEngine Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants