-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASH-622] DMFile implementation #327
Conversation
flowbehappy
commented
Nov 22, 2019
- Import DMFile
- Temporary disable test cases of DDL and Segment merge
@@ -0,0 +1,65 @@ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can move to Storages/DeltaMerge/File
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep it, more information could add into later.
|
||
size_t StableValueSpace::getBytes() | ||
{ | ||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe later, we don't use bytes for now.
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
/run-integration-tests |
I rebase and use ReorganizeBlockInputStream to tidy up the boundary of chunks. #330 |
/run-integration-tests |
1 similar comment
/run-integration-tests |