[FLASH-530] Reclaim obsolete meta file in PageStorage #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiysky
changed the title
leiysky
changed the title
| @@ -17,7 +18,7 @@ extern const int LOGICAL_ERROR; | |||
| } // namespace ErrorCodes | |||
|
|
|||
| std::set<PageFile, PageFile::Comparator> | |||
| PageStorage::listAllPageFiles(const String & storage_path, bool remove_tmp_file, bool ignore_legacy, Logger * page_file_log) | |||
| PageStorage::listAllPageFiles(const String & storage_path, Poco::Logger * page_file_log, ListPageFilesOption option) | |||
There was a problem hiding this comment.
Please add some tests for this function.
dbms/src/Storages/Page/PageStorage.h
Outdated
| listAllPageFiles(const String & storage_path, bool remove_tmp_file, bool ignore_legacy, Poco::Logger * page_file_log); | ||
| listAllPageFiles(const String & storage_path, Poco::Logger * page_file_log, ListPageFilesOption option = ListPageFilesOption()); | ||
|
|
||
| static std::optional<PageFile> tryGetLastSnapshot(const String & storage_path, Poco::Logger * page_file_log, bool remove_old = false); |
There was a problem hiding this comment.
tryGetLastSnapshot here is easily confuse with getSnapshot, maybe Checkpoint for PageFile is better?
There was a problem hiding this comment.
And also replace these "snapshot" with "checkpoint".
PageFile::Type::Snapshot, PageFile::folder_prefix_snapshot, PageStorage::ListPageFilesOption::ignore_snapshot
Signed-off-by: leiysky <leiysky@outlook.com>
Signed-off-by: leiysky <leiysky@outlook.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
|
/run-integration-tests |
3 similar comments
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
12 tasks
This was referenced Sep 4, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can safely remove neighbouring meta files if they are both legacy.