Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASH-316] Fix atomic write at DeltaMergeStore level for disk #390

Merged
merged 3 commits into from
Jan 29, 2020
Merged

[FLASH-316] Fix atomic write at DeltaMergeStore level for disk #390

merged 3 commits into from
Jan 29, 2020

Conversation

JaySon-Huang
Copy link
Contributor

  • Previous we commit changes of disk for each segment but not DeltaMergeStore level. In this PR, I put the commit to WriteBatches.meta and commit them at DeltaMergeStore level. See DeltaMergeStore::commitWrites for details.
  • Refine include headers for StorageDeltaMerge.h so that we can reduce files need to to recompiled.

@JaySon-Huang
Copy link
Contributor Author

/rebuild

@JaySon-Huang
Copy link
Contributor Author

/run-integration-tests

@JaySon-Huang JaySon-Huang force-pushed the refine-include-headers branch 3 times, most recently from e0e07ee to ee59215 Compare January 17, 2020 03:19
@JaySon-Huang
Copy link
Contributor Author

/run-integration-tests

@JaySon-Huang
Copy link
Contributor Author

/rebuild

@JaySon-Huang
Copy link
Contributor Author

/build

@JaySon-Huang
Refine include headers
c58ff35 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Atomic commit changes of delta at DeltaMergeStore level
b301ab1 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
remove unused codes
60085ed 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang force-pushed the refine-include-headers branch from c4f5b74 to 60085ed Compare January 19, 2020 07:32
@JaySon-Huang

This comment has been minimized.

Sign in to view
@JaySon-Huang
Copy link
Contributor Author

/rebuild

@flowbehappy flowbehappy merged commit 7031b81 into pingcap:DeltaMergeEngine Jan 29, 2020
@JaySon-Huang JaySon-Huang deleted the refine-include-headers branch September 27, 2020 09:24
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaySon-Huang @flowbehappy