Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty segment cannot merge after gc #4522

Merged

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 30, 2022

This is an cherry-pick of #4500

What problem does this PR solve?

Issue Number: close #4511

Problem Summary:

  1. empty segments cannot be merged after gc;
  2. when a segment can be triggerred to gc because of too many delete range, we still wait for the gc_safe_point change, which is not needed.

What is changed and how it works?

  1. when segment should be gced because of too many delete range, do it regardless of the gc_safe_point;
  2. only update index cache for read thread;
  3. fix unstable rough set filter test because of more fast gc speed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. load data into tiflash and check segment status;
    image
  2. set tiflash replica to 0 and check segment status after a while
    image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the problem that empty segments cannot be merged after gc

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 30, 2022
@lidezhu lidezhu added CHERRY-PICK cherry pick type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Mar 30, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 31, 2022

/rebuild

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2022
@lidezhu lidezhu force-pushed the cherry-pick-4500-to-release-5.4 branch from 9823a31 to 29df374 Compare March 31, 2022 07:12
@lidezhu lidezhu force-pushed the cherry-pick-4500-to-release-5.4 branch from 29df374 to fe6af2c Compare March 31, 2022 07:38
@flowbehappy flowbehappy self-requested a review March 31, 2022 08:59
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022

CLA assistant check
All committers have signed the CLA.

@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 19, 2022

/rebuild

1 similar comment
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 19, 2022

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 19, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 19, 2022

lines: 43.3% (49809 out of 115126)
branches: 6.4% (81421 out of 1263896)

@JaySon-Huang JaySon-Huang added this to the v5.4.1 milestone Apr 21, 2022
@lidezhu lidezhu self-assigned this Apr 21, 2022
@lidezhu lidezhu changed the title fix empty segment cannot merge after gc and avoid write index data fo… fix empty segment cannot merge after gc Apr 25, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 25, 2022

/run-all-tests

1 similar comment
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 25, 2022

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 26, 2022

@JaySon-Huang PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9e7102b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 26, 2022

lines: 43.3% (49975 out of 115355)
branches: 6.5% (81768 out of 1265193)

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 26, 2022

lines: 43.3% (49974 out of 115355)
branches: 6.5% (81762 out of 1265193)

@ti-chi-bot ti-chi-bot merged commit 89187f3 into pingcap:release-5.4 Apr 26, 2022
@lidezhu lidezhu deleted the cherry-pick-4500-to-release-5.4 branch April 26, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants