Optimize Structure And Format #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
|
/run-integration-tests |
innerr
reviewed
Apr 23, 2019
|
|
||
| // Remove region's data from partition | ||
| // Usage: | ||
| // ./storage-client.sh "DBGInvoke rm_region_data(region_id)" | ||
| void dbgFuncRegionRmData(Context & context, const ASTs & args, DBGInvoker::Printer output); | ||
|
|
||
| void dbgFuncDumpAllRegion(Context& context, const ASTs& args, DBGInvoker::Printer output); | ||
| void dbgFuncDumpAllRegion(Context & context, const ASTs & args, DBGInvoker::Printer output); |
There was a problem hiding this comment.
We should use the CH-style Context & context
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By now, the way we add head files is very casual. We should try to avoid including a head file in another head file unless we need to define the memory structure. This PR fix most of unreasonable behaviors.