feat: delta tree dispatching #5199

SchrodingerZhu · 2022-06-23T01:24:20Z

What problem does this PR solve?

Issue Number: close #5200

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-06-23T01:24:22Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Lloyd-Pottiger
flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

SchrodingerZhu · 2022-06-23T01:33:27Z

/build

SchrodingerZhu · 2022-06-23T02:08:24Z

/build

SchrodingerZhu · 2022-06-23T02:18:15Z

/build

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

SchrodingerZhu · 2022-06-23T02:35:17Z

/build

SchrodingerZhu · 2022-06-23T02:47:08Z

/run-all-tests

SchrodingerZhu · 2022-06-23T02:49:26Z

/run-unit-tests

sre-bot · 2022-06-23T03:10:16Z

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/DeltaTree.h         464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18385      9657             47.47%    206716  96713        53.21%

full coverage report (for internal network access only)

Lloyd-Pottiger · 2022-06-24T00:54:21Z

dbms/src/Storages/DeltaMerge/DeltaTree.ipp

+
+    constexpr bool is_leaf = std::is_same<Leaf, T>::value;
+
+    if (root == asNode(node) && !isLeaf(root) && node->count == 1)


maybe add some comments about each case? And the entire function.

Hi, this was the original function, which is just moved to the ipp file. But yes, I guess the DeltaTree data structure itself is lack of comment.

the rest LGTM.

SchrodingerZhu · 2022-06-24T03:56:02Z

/merge

@Lloyd-Pottiger let us see what we can add to comment in a separate PR then

ti-chi-bot · 2022-06-24T03:56:03Z

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-06-24T03:56:04Z

This pull request has been accepted and is ready to merge.

Commit hash: 39875d4

sre-bot · 2022-06-24T04:08:51Z

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/DeltaTree.h         464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18385      9657             47.47%    206716  96700        53.22%

full coverage report (for internal network access only)

SchrodingerZhu · 2022-06-24T05:00:02Z

/run-integration-test

SchrodingerZhu · 2022-06-24T08:51:24Z

/merge

ti-chi-bot · 2022-06-24T08:51:25Z

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-06-24T09:02:57Z

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/DeltaTree.h         464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18385      9657             47.47%    206716  96718        53.21%

full coverage report (for internal network access only)

SchrodingerZhu · 2022-06-24T12:10:01Z

/merge

ti-chi-bot · 2022-06-24T12:10:02Z

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-06-24T12:25:25Z

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/DeltaTree.h         464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       464                69    85.13%          96                 6    93.75%         736                97    86.82%         272                74    72.79%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18385      9656             47.48%    206716  96695        53.22%

full coverage report (for internal network access only)

…s in README (pingcap#5182) close pingcap#5172, ref pingcap#5178 Enhancement: add a integrated test on DDL module (pingcap#5130) ref pingcap#5129 Revert "Revise default background threads size" (pingcap#5176) close pingcap#5177 chore: remove extra dyn cast (pingcap#5186) close pingcap#5185 Add MPPReceiverSet, which includes ExchangeReceiver and CoprocessorReader (pingcap#5175) ref pingcap#5095 DDL: Use Column Name Instead of Offset to Find the common handle cluster index (pingcap#5166) close pingcap#5154 Add random failpoint in critical paths (pingcap#4876) close pingcap#4807 Segment test framework (pingcap#5150) close pingcap#5151 optimize ps v3 restore (pingcap#5163) ref pingcap#4914 Fix build failed (pingcap#5196) close pingcap#5195 feat: delta tree dispatching (pingcap#5199) close pingcap#5200 feat: introduce specialized API to write fixed length data rapidly (pingcap#5181) close pingcap#5183 Add gtest for Limit, TopN, Projection (pingcap#5187) (pingcap#5188) close pingcap#5187 add `MPPTask::handleError()` (pingcap#5202) ref pingcap#5095 Check result of starting grpc server (pingcap#5257) close pingcap#5255 feat: add optimized routines for aarch64 (pingcap#5231) close pingcap#5240 fix: aarch64-quick-fix (pingcap#5259) close pingcap#5260 Update client-c to support ipv6 (pingcap#5270) close pingcap#5247 upgrade prometheus-cpp to v1.0.1 (pingcap#5279) ref pingcap#2103, close pingcap#5278 Fix README type error (pingcap#5273) ref pingcap#5178 fix(cmake): make sure libc++ is utilized by tiflash-proxy (pingcap#5281) close pingcap#5282 fix the wrong order of execution summary for list based executors (pingcap#5242) close pingcap#5241 Schema: allow loading empty schema diff when the version grows up. (pingcap#5245) close pingcap#5244 Optimize apply speed under heavy write pressure (pingcap#4883) ref pingcap#4728 update proxy to raftstore-proxy-6.2 (pingcap#5287) ref pingcap#4982 Flush segment cache when doing the compaction (pingcap#5284) close pingcap#5179 metrics: Fix incorrect metrics for delta_merge tasks (pingcap#5061) close pingcap#5055 dep: upgrade jemalloc (pingcap#5197) close pingcap#5258 *: TiFlash pagectl/dttool use only-decryption mode (pingcap#5271) close pingcap#5122 suppresion false positive report from tsan (pingcap#5303) close pingcap#5088 Refine test framework code and tests (pingcap#5261) close pingcap#5262 feat: add logical cpu cores and memory into grafana (pingcap#5124) close pingcap#3821 Implement TimeToSec function push down (pingcap#5235) close pingcap#5116 feat: implement shiftRight function push down (pingcap#5156) close pingcap#5100 schema : make update to partition tables when 'set tiflash replica' (pingcap#5267) close pingcap#5266 Replace initializer_list with vector for planner test framework (pingcap#5307) close pingcap#5295 KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data (pingcap#5283) ref pingcap#5170 refine error message in mpptask (pingcap#5304) ref pingcap#5095 Implement ReverseUTF8/Reverse function push down (pingcap#5233) close pingcap#5111 Optimize comparision for collation `UTF8_BIN` and `UTF8MB4_BIN` (pingcap#5299) ref pingcap#5294 feat : support set tiflash mode ddl action (pingcap#5256) ref pingcap#5252 Add non-blocking functions for MPMCQueue (pingcap#5311) close pingcap#5310 add random segment test for CI weekly (pingcap#5300) close pingcap#5301 *: tidy FunctionString.cpp (pingcap#5312) close pingcap#5313 ci: fix check-license github action (pingcap#5318) close pingcap#5317 update proxy to raftstore-proxy-6.2 (pingcap#5316) ref pingcap#4982 Change one `additional_input_at_end` to many streams in `ParallelInputsProcessor` (pingcap#5274) close pingcap#4856, close pingcap#5263 support fine grained shuffle for window function (pingcap#5048) close pingcap#5142 feat: pushdown get_format into TiFlash (pingcap#5269) close pingcap#5115 fix: format throw data truncated error (pingcap#5272) close pingcap#4891 Print content of columns for gtest (pingcap#5243) close pingcap#5203 *: also enable O3 for aarch64 (pingcap#5338) close pingcap#5342 Add debug image build target for CentOS7 (pingcap#5344) close pingcap#5343 *: mini refactor (pingcap#5326) close pingcap#4739 Refactor initialize of background pool (pingcap#5190) close pingcap#5189 delete copy/move ctor of MPMCQueue explicitly (pingcap#5328) close pingcap#5329 Introduce proxy_server and new-mock-engine-store (pingcap#5319) ref pingcap#5170 fix: incorrect uptime in grafana panel Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

close pingcap#5200

ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 23, 2022

SchrodingerZhu requested review from Lloyd-Pottiger and fuzhe1989 and removed request for Lloyd-Pottiger June 23, 2022 01:24

ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 23, 2022

SchrodingerZhu requested review from Lloyd-Pottiger and JinheLin June 23, 2022 01:24

ti-chi-bot removed the do-not-merge/needs-linked-issue label Jun 23, 2022

SchrodingerZhu added 2 commits June 23, 2022 10:23

feat: delta tree dispatch

f12e85e

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

chore: add lic header

169d855

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

SchrodingerZhu force-pushed the feat/delta-tree-dispatching branch from c26b102 to 169d855 Compare June 23, 2022 02:23

fix: dup symbol

39875d4

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

Lloyd-Pottiger reviewed Jun 24, 2022

View reviewed changes

Lloyd-Pottiger approved these changes Jun 24, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2022

flowbehappy approved these changes Jun 24, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2022

ti-chi-bot merged commit dab31a5 into pingcap:master Jun 24, 2022

Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 19, 2022

feat: delta tree dispatching (pingcap#5199)

2fe36c7

close pingcap#5200

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: delta tree dispatching #5199

feat: delta tree dispatching #5199

SchrodingerZhu commented Jun 23, 2022 •

edited

Loading

ti-chi-bot commented Jun 23, 2022 •

edited

Loading

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

sre-bot commented Jun 23, 2022

Lloyd-Pottiger Jun 24, 2022

SchrodingerZhu Jun 24, 2022

Lloyd-Pottiger Jun 24, 2022

SchrodingerZhu commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

sre-bot commented Jun 24, 2022

SchrodingerZhu commented Jun 24, 2022

SchrodingerZhu commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

sre-bot commented Jun 24, 2022

SchrodingerZhu commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

sre-bot commented Jun 24, 2022


		constexpr bool is_leaf = std::is_same<Leaf, T>::value;

		if (root == asNode(node) && !isLeaf(root) && node->count == 1)

feat: delta tree dispatching #5199

feat: delta tree dispatching #5199

Conversation

SchrodingerZhu commented Jun 23, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jun 23, 2022 • edited Loading

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

SchrodingerZhu commented Jun 23, 2022

sre-bot commented Jun 23, 2022

Coverage for changed files

Coverage summary

Lloyd-Pottiger Jun 24, 2022

Choose a reason for hiding this comment

SchrodingerZhu Jun 24, 2022

Choose a reason for hiding this comment

Lloyd-Pottiger Jun 24, 2022

Choose a reason for hiding this comment

SchrodingerZhu commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

sre-bot commented Jun 24, 2022

Coverage for changed files

Coverage summary

SchrodingerZhu commented Jun 24, 2022

SchrodingerZhu commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

sre-bot commented Jun 24, 2022

Coverage for changed files

Coverage summary

SchrodingerZhu commented Jun 24, 2022

ti-chi-bot commented Jun 24, 2022

sre-bot commented Jun 24, 2022

Coverage for changed files

Coverage summary

SchrodingerZhu commented Jun 23, 2022 •

edited

Loading

ti-chi-bot commented Jun 23, 2022 •

edited

Loading