-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a panic issue in parallel agg when exception is thrown (#5433) #5443
fix a panic issue in parallel agg when exception is thrown (#5433) #5443
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: gengliqi <gengliqiii@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1b7d589
|
lines: 36.2% (43328 out of 119733) |
This is an automated cherry-pick of #5433
Signed-off-by: gengliqi gengliqiii@gmail.com
What problem does this PR solve?
Issue Number: close #5356
Problem Summary:
See #5356.
What is changed and how it works?
See #5356 (comment).
Although the panic doesn't happen by lucky coincidence due to #5274, this PR is still needed for previous branches.
It's easier to pick this PR to other branches than #5274.
The
ParallelAggregatingBlockInputStream
should be canceled when its processors meet an exception.Otherwise, the aggregation of non-joined data will still process which leads to panic like #5356 shows.
Check List
Tests
Side effects
Documentation
Release note