-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support elt pushdown #5496
Merged
Merged
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e5ae491
feat: implement basic elt push down
Willendless 52e8475
chore: remove useless headers
Willendless 194d2e6
feat: add ut framework
Willendless 556bf4d
fix: resolve const nullable and columnstring bugs
Willendless 08b235e
feat: enhance ut
Willendless 38d15df
chore: add integration test
Willendless b8ad8a8
chore: format
Willendless ea8d24a
chore: update integration test
Willendless 39921bc
chore: fix typo
Willendless 03608ce
chore: name first arg col from col_idx to col_arg0
Willendless 012b780
chore: refine test code
Willendless f2f6f80
Merge branch 'pingcap:master' into support-elt-pushdown
Willendless 658ae08
chore: refine code
Willendless ecb79bf
test: enhance ut
Willendless 1affed0
fix: resolve vector const bug
Willendless e94333d
chore: format code
Willendless 79e1ef1
chore: refine comment
Willendless a2b67c6
chore: add const modifier
Willendless 81ebb92
chore: refine comment
Willendless 5d00837
Merge branch 'master' into support-elt-pushdown
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable's name may be inappropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will use arg0 instead