-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable folly memcpy as default memcpy #5996
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4dccd63
|
/hold |
/merge |
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/unhold |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
In response to a cherrypick label: new pull request created: #6001. |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
What problem does this PR solve?
Issue Number: close #5949
Problem Summary:
since #5834
MemUtils benchmark show that
__folly_memcpy
is not friendlyWhen memory size > 32K(L1 cache size) and both address are aligned to 32,
__folly_memcpy
will use non-temporal way(mark data unlikely to be used again soon) to minimize caching. It causes big performance regression.tiflash/libs/libmemcpy/folly/memcpy.S
Lines 329 to 353 in bd16255
What is changed and how it works?
For b232bcd, the result is
Before this PR
After this PR
Check List
Tests
Side effects
Documentation
Release note