Fix I/O limiter auto-tuner.

[JinheLin]

What problem does this PR solve?

Issue Number: close #6099

What is changed and how it works?

Try to tune bandwidth quota between read-bandwidth-quota and write-bandwidth-quota if bandwidth quota of bg_read/fg_read (or bg_write/fg_write) is small.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Lloyd-Pottiger
• flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JinheLin]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
RateLimiter.cpp                      635               286    54.96%          46                13    71.74%         716               290    59.50%         298               131    56.04%
RateLimiter.h                         70                 3    95.71%          27                 3    88.89%         102                23    77.45%          34                 6    82.35%
tests/gtest_rate_limiter.cpp         322                60    81.37%          42                 0   100.00%         739                20    97.29%          56                10    82.14%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               1027               349    66.02%         115                16    86.09%        1557               333    78.61%         388               147    62.11%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18392      7446             59.52%    215549  76511        64.50%

full coverage report (for internal network access only)

[JinheLin]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
RateLimiter.cpp                      635               286    54.96%          46                13    71.74%         716               290    59.50%         298               132    55.70%
RateLimiter.h                         70                 3    95.71%          27                 3    88.89%         102                23    77.45%          34                 6    82.35%
tests/gtest_rate_limiter.cpp         322                61    81.06%          42                 0   100.00%         739                20    97.29%          56                10    82.14%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               1027               350    65.92%         115                16    86.09%        1557               333    78.61%         388               148    61.86%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18392      7443             59.53%    215549  76458        64.53%

full coverage report (for internal network access only)

[JinheLin]

/run-all-tests

[JinheLin]

/run-unit-test

[JinheLin]

/run-unit-test

[sre-bot]

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
RateLimiter.cpp                      635               286    54.96%          46                13    71.74%         716               290    59.50%         298               132    55.70%
RateLimiter.h                         70                 3    95.71%          27                 3    88.89%         102                23    77.45%          34                 6    82.35%
tests/gtest_rate_limiter.cpp         322                61    81.06%          42                 0   100.00%         739                20    97.29%          56                10    82.14%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               1027               350    65.92%         115                16    86.09%        1557               333    78.61%         388               148    61.86%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18392      7441             59.54%    215549  76415        64.55%

full coverage report (for internal network access only)

[Lloyd-Pottiger]

LGTM

[JinheLin]

/run-all-tests

[JinheLin]

/run-unit-test

[sre-bot]

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
RateLimiter.cpp                      635               286    54.96%          46                13    71.74%         716               290    59.50%         298               131    56.04%
RateLimiter.h                         70                 3    95.71%          27                 3    88.89%         102                23    77.45%          34                 6    82.35%
tests/gtest_rate_limiter.cpp         322                61    81.06%          42                 0   100.00%         739                20    97.29%          56                10    82.14%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               1027               350    65.92%         115                16    86.09%        1557               333    78.61%         388               147    62.11%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18392      7443             59.53%    215549  76469        64.52%

full coverage report (for internal network access only)

[flowbehappy]

LGTM

[JinheLin]

/merge

[ti-chi-bot]

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 0c375ca

[ti-chi-bot]

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
RateLimiter.cpp                      616               277    55.03%          46                13    71.74%         716               290    59.50%         298               132    55.70%
RateLimiter.h                         70                 3    95.71%          27                 3    88.89%         102                23    77.45%          34                 6    82.35%
tests/gtest_rate_limiter.cpp         322                61    81.06%          42                 0   100.00%         739                20    97.29%          56                10    82.14%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               1008               341    66.17%         115                16    86.09%        1557               333    78.61%         388               148    61.86%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18356      7408             59.64%    215283  76257        64.58%

full coverage report (for internal network access only)

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #6107.