Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent result before deleting some rows #6133

Merged
merged 4 commits into from
Oct 15, 2022
Merged

fix inconsistent result before deleting some rows #6133

merged 4 commits into from
Oct 15, 2022

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Oct 14, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6127

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2022
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker /cc @ywqzzy

@ti-chi-bot
Copy link
Member

@xzhangxian1008: GitHub didn't allow me to request PR reviews from the following users: /cc.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @windtalker /cc @ywqzzy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008
Copy link
Contributor Author

/cc @SeaRise

@ti-chi-bot ti-chi-bot requested a review from SeaRise October 14, 2022 04:11
windtalker
windtalker reviewed Oct 14, 2022
View reviewed changes
dbms/src/Functions/FunctionsLogical.h Outdated
@@ -240,7 +242,8 @@ struct AssociativeOperationImpl<Op, 1>

inline UInt8 apply(size_t i) const
{
return vec[i];
// Searching keyword "cast_bool_reason" in this file to get the reason for static_cast<bool>
return static_cast<bool>(vec[i]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can change the return type of apply to bool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can change the return type of apply to bool?

okk

@xzhangxian1008 xzhangxian1008 requested review from windtalker and removed request for SeaRise and ywqzzy October 14, 2022 04:51
@xzhangxian1008
Copy link
Contributor Author

/cc @ywqzzy @SeaRise

@ti-chi-bot ti-chi-bot requested review from SeaRise and ywqzzy October 14, 2022 04:51
@JaySon-Huang

This comment was marked as resolved.

Sign in to view
windtalker
windtalker approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 14, 2022
@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 and removed do-not-merge/needs-triage-completed labels Oct 15, 2022
@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b3fd8cf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 15, 2022
@ti-chi-bot
Copy link
Member

@xzhangxian1008: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1e0e3c8 into pingcap:master Oct 15, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6139.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 15, 2022
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#6133
663f681 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6140.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6141.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6142.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6143.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6144.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 15, 2022
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#6133
0271a85 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6145.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 15, 2022
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#6133
ecc8c9f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2022
Merged
12 tasks
@xzhangxian1008 xzhangxian1008 deleted the issue_6127 branch October 15, 2022 03:17
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
fix inconsistent result before deleting some rows (#6133) (#6141)
b26120e 
close #6127
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
fix inconsistent result before deleting some rows (#6133) (#6140)
f3952aa 
close #6127
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
fix inconsistent result before deleting some rows (#6133) (#6145)
97088c2 
close #6127
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
fix inconsistent result before deleting some rows (#6133) (#6144)
4dd22a4 
close #6127
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
fix inconsistent result before deleting some rows (#6133) (#6139)
eda89d2 
close #6127
ti-chi-bot added a commit that referenced this pull request Oct 28, 2022
@ti-chi-bot
fix inconsistent result before deleting some rows (#6133) (#6142)
83ac860 
close #6127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise Awaiting requested review from SeaRise

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.3 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the result is inconsistent before deleting some rows
5 participants
@xzhangxian1008 @ti-chi-bot @JaySon-Huang @windtalker @ywqzzy