Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update proxy of master to raftstore-proxy #7704

Merged
merged 10 commits into from
Jun 30, 2023
Merged

update proxy of master to raftstore-proxy #7704

merged 10 commits into from
Jun 30, 2023

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jun 27, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4982 close #7700

Problem Summary:
update proxy to raftstore-proxy
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy 023c4e7261..2aa1940f72:

Support replace url with a host string (#337)
Use addr's ip if status_addr's is is empty (#334)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
update tiflash proxy to proxy_up/raftstore-proxy
d3a19a5 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 28, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-28 02:07:46.367297861 +0000 UTC m=+759831.768548309: ☑️ agreed by hongyunyan.
  • 2023-06-28 02:52:27.835969178 +0000 UTC m=+762513.237219627: ☑️ agreed by JaySon-Huang.

@CalvinNeo
Copy link
Member Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2023

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, hongyunyan, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

/merge

@CalvinNeo
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@CalvinNeo
update tiflash proxy to proxy_up/use-back-addr-3
cd9e121 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo changed the title update proxy of master to raftstore-proxy update proxy of master to use-back-addr-3 Jun 28, 2023
@CalvinNeo CalvinNeo force-pushed the update_proxy_20230627_172024 branch from 295808b to cd9e121 Compare June 28, 2023 03:59
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
Copy link
Member Author

/run-build-release comment=true

@CalvinNeo
a
490b88d 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
Copy link
Member Author

/run-build-release comment=true

@CalvinNeo
k
4df805a 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-build-release comment=true

@CalvinNeo
Copy link
Member Author

/run-integration-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 28, 2023

download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/490b88df6c81708e7c7b67f9c013d79daa6a16ac/centos7/tiflash-linux-amd64.tar.gz

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 28, 2023

download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/4df805ae985189fe16db589b619669c7e3e992df/centos7/tiflash-linux-amd64.tar.gz

@CalvinNeo
info
6490a52 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
hh
a0465c7 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
hh2
5a33a94 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
Copy link
Member Author

/rebuild

@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo CalvinNeo changed the title update proxy of master to use-back-addr-3 update proxy of master to raftstore-proxy Jun 29, 2023
@CalvinNeo
Copy link
Member Author

/merge

@CalvinNeo
Copy link
Member Author

/run-unit-test

@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

/run-unit-test

@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit b3f9fed into pingcap:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongyunyan hongyunyan hongyunyan approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dynamic Region] cluster's raftstore version is Uncertain
4 participants
@CalvinNeo @sre-bot @JaySon-Huang @hongyunyan