Update the weight function for Mark Cache and Min Max Index Cache (#8058) #8066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
12 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XL
ti-chi-bot
bot
added
size/L
hongyunyan
approved these changes
Sep 7, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
JaySon-Huang
approved these changes
Sep 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
added
the
cherry-pick-approved
|
/run-all-tests |
ti-chi-bot
bot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8058, and cherry-pick of #6861
What problem does this PR solve?
Issue Number: ref #8050
Problem Summary:
Update the weight function for Mark Cache and Min Max Index Cache
What is changed and how it works?
We only calculate the inner value weight as the cost of LRUCache now, while sometimes the memory cost of key and structural part also occupy a lot, especially when the pack number is quite small.
Thus, we update the weight function of mark cache and minmax index cache, to provider more accurate memory calculation(while it's still an approximate memory usage, but more accurate approximat).
Besides, we add the metrics for minmax cache index, and add their correponding panel in grafana.
In test we can see the whole memory gap is similar with the memory gap of mark cache and minmax index cache.
Check List
Tests
Side effects
Documentation
Release note