-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix zero safepoint make schema gc run repeatly #8361
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/run-unit-test |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #8356
Problem Summary:
After a new tidb cluster deployed, there is an interval that PD will return gc safepoint with 0
This will lead to
SchemaSyncService::gc
running repeatedly. This results in lots of useless logging and getting gc safepoint from pd frequently.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note