Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid out of bound InsertRangeFrom exception in MergingSortedBlockInputStream (#8445) #8452

Closed
wants to merge 6 commits into from
Closed

Avoid out of bound InsertRangeFrom exception in MergingSortedBlockInputStream (#8445) #8452

wants to merge 6 commits into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8445

What problem does this PR solve?

Issue Number: close #8438

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@yibin87 @ti-chi-bot
Protect merged row size
19105fd 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Little update
84f993a 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Address comments
5af1e37 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Little refact
af79be5 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Address comments
d0df18c 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Dec 4, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 4, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 5, 2023
@yibin87
Copy link
Contributor

yibin87 commented Dec 7, 2023

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@yibin87 you're already a collaborator in repo ti-chi-bot/tiflash

@yibin87
Fix compilation issue
e231666 
Signed-off-by: yibin <huyibin@pingcap.com>
yibin87
yibin87 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xzhangxian1008
xzhangxian1008 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xzhangxian1008, yibin87

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yibin87 yibin87 closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

@yibin87 yibin87

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @yibin87 @xzhangxian1008