Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support json_extract(column, column, ...) #8555

Merged
merged 9 commits into from
Jan 9, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Dec 19, 2023

What problem does this PR solve?

Issue Number: close #8510

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 19, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 19, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 19, 2023

/run-unit-test

dbms/src/Functions/FunctionsJson.h Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsJson.h Outdated Show resolved Hide resolved
Co-authored-by: xufei <xufei@pingcap.com>
dbms/src/Functions/FunctionsJson.h Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsJson.h Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsJson.h Outdated Show resolved Hide resolved
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 8, 2024
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 05:42:14.564239453 +0000 UTC m=+249124.148493140: ☑️ agreed by windtalker.
  • 2024-01-08 11:46:36.35943949 +0000 UTC m=+270985.943693162: ☑️ agreed by yibin87.

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 8, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit e317f2a into pingcap:master Jan 9, 2024
6 checks passed
@SeaRise SeaRise deleted the fix_issue_8510 branch January 9, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
3 participants