-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cancel in AsyncTasks #8581
Merged
Merged
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b140fee
split
CalvinNeo 83de074
fix
CalvinNeo d5a575e
kvstore helper
CalvinNeo e7f2037
f
CalvinNeo c15e033
Merge branch 'master' into improve-async-tasks
CalvinNeo 58cc593
reorg region.h
CalvinNeo 64f8e94
Merge branch 'improve-async-tasks' of github.com:CalvinNeo/tics into …
CalvinNeo 2f937fe
fix tests
CalvinNeo 941206d
add test
CalvinNeo 624f5a2
fmt
CalvinNeo 9e37bcb
fix tests
CalvinNeo 7ae303e
f
CalvinNeo f7ec15a
Update dbms/src/Storages/KVStore/Utils/AsyncTasks.h
CalvinNeo bea605b
address
CalvinNeo 453a44c
Merge branch 'improve-async-tasks' of github.com:CalvinNeo/tics into …
CalvinNeo 8a90161
fix comments
CalvinNeo 713e354
fix comments
CalvinNeo 9bbc529
address name
CalvinNeo 8c1535a
Merge branch 'master' into improve-async-tasks
CalvinNeo 56059f1
Update dbms/src/Storages/KVStore/Utils/AsyncTasks.h
CalvinNeo ccc2490
f
CalvinNeo 42ece5f
Merge branch 'improve-async-tasks' of github.com:CalvinNeo/tics into …
CalvinNeo 6d39de5
a
CalvinNeo b9cd8e4
Merge branch 'master' into improve-async-tasks
CalvinNeo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what situation will we run into this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a cancel happens in
addTaskWithCancel
betweenif (cancel_handle->canceled())
, and the inner invokable object of(*p)()
actually called(after theaddTaskWithCancel
quitted and release the lock).It is very slightly chance.