Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KVStore: Distinguish different versions of Proxy #9078

Merged
merged 12 commits into from
May 24, 2024
Merged

KVStore: Distinguish different versions of Proxy #9078

merged 12 commits into from
May 24, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented May 23, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8382

Problem Summary:

What is changed and how it works?

Distinguish different versions of Proxy

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo added 4 commits May 23, 2024 13:46
@CalvinNeo
z
c312de6 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
a
a5174b3 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
metrics
15d9ef9 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
a
5f3bc04 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels May 23, 2024
@CalvinNeo
Copy link
Member Author

/cc @JaySon-Huang @yongman @JinheLin @Lloyd-Pottiger

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2024

@yongman: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Lloyd-Pottiger
Lloyd-Pottiger reviewed May 23, 2024
View reviewed changes
cmake/find_tiflash_proxy.cmake Outdated
Comment on lines 51 to 53
# SERVERLESS_PROXY=0 if using normal proxy.
# SERVERLESS_PROXY=1 if using serverless proxy.
add_definitions(-DSERVERLESS_PROXY=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

if (EXISTS "${TiFlash_SOURCE_DIR}/contrib/tiflash-proxy/xxx/xxx")
   add_definitions(-DSERVERLESS_PROXY=1)
else ()
   add_definitions(-DSERVERLESS_PROXY=0)
endif ()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can use rfstore

CalvinNeo added 2 commits May 24, 2024 11:26
@CalvinNeo
a
e277e02 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Merge branch 'serverless-proxy' of github.com:CalvinNeo/tics into ser…
b95577d 
…verless-proxy
@CalvinNeo CalvinNeo requested a review from Lloyd-Pottiger May 24, 2024 03:51
Lloyd-Pottiger
Lloyd-Pottiger reviewed May 24, 2024
View reviewed changes
dbms/src/Storages/KVStore/MultiRaft/Disagg/FastAddPeer.cpp Outdated
auto segments = dm_storage->buildSegmentsFromCheckpointInfo(new_key_range, checkpoint_info, settings);
GET_METRIC(tiflash_fap_task_duration_seconds, type_write_stage_build).Observe(sbuild.elapsedSeconds());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use elapsedSecondsFromLastTime() can avoid build multiple watch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

dbms/src/Storages/KVStore/MultiRaft/PrehandleSnapshot.cpp Outdated Show resolved Hide resolved
CalvinNeo and others added 3 commits May 24, 2024 13:24
@CalvinNeo @Lloyd-Pottiger
Update dbms/src/Storages/KVStore/MultiRaft/PrehandleSnapshot.cpp
c398591 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@CalvinNeo
d
fac93c1 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Merge branch 'serverless-proxy' of github.com:CalvinNeo/tics into ser…
2883d9c 
…verless-proxy
@CalvinNeo CalvinNeo requested a review from Lloyd-Pottiger May 24, 2024 05:32
@CalvinNeo
fmt
403ee44 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 24, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger, yongman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 24, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-24 07:25:18.964712843 +0000 UTC m=+2415672.721848412: ☑️ agreed by Lloyd-Pottiger.
  • 2024-05-24 07:26:06.265948773 +0000 UTC m=+2415720.023084346: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 552becc into pingcap:master May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

@yongman yongman yongman approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce two stages FAP
4 participants
@CalvinNeo @yongman @JinheLin @Lloyd-Pottiger