storage: fix block rows not match when filter column is the first non-empty column in the block #9484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-empty column in the block Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
ti-chi-bot
bot
added
release-note-none
JinheLin
approved these changes
Sep 27, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
|
/retest |
|
/test pull-integration-test |
1 similar comment
|
/test pull-integration-test |
|
fullstack-test2/ddl/rename_table_across_databases.test |
|
/retest |
ti-chi-bot
bot
added
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9472
Problem Summary:
What is changed and how it works?
Try to fix #9472, failed to reproduce the issue. But when the filter column is the first non-empty column in the block, block.rows() = filter_column->size(), but filter_column is not filtered, so the rows may not match.
But filter_column is usually added to the back of the block, so it is kind of weird.
Check List
Tests
Side effects
Documentation
Release note