Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix TypeBit default value (#9467) #9579

Merged
merged 5 commits into from
Nov 4, 2024
Merged

ddl: fix TypeBit default value (#9467) #9579

merged 5 commits into from
Nov 4, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Nov 1, 2024 •
edited by JaySon-Huang
Loading

cherry-pick of #9467

What problem does this PR solve?

Issue Number: close #9461

Problem Summary:

What is changed and how it works?

Fix two problems:

  1. When the default value of TypeBit contains invalid characters (like 0x07 or 0x08), TiFlash fails to parse the schema JSON.
  2. The default value of TypeBit is origin_default_bit_value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
fix
862b87a 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Nov 1, 2024
@Lloyd-Pottiger Lloyd-Pottiger changed the title ddl: fix TypeBit default value ddl: fix TypeBit default value [cherry-pick 9467] Nov 1, 2024
@Lloyd-Pottiger
fix
1b76154 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
fix ut
85dbaa9 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Lloyd-Pottiger and others added 2 commits November 4, 2024 10:08
@Lloyd-Pottiger
Merge branch 'release-7.1' into fix-bit-default-7.1
a2a13f2
@Lloyd-Pottiger
format
f5f71de 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@JaySon-Huang JaySon-Huang changed the title ddl: fix TypeBit default value [cherry-pick 9467] ddl: fix TypeBit default value (#9467) Nov 4, 2024
JaySon-Huang
JaySon-Huang approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 4, 2024
CalvinNeo
CalvinNeo approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 03:32:38.104876025 +0000 UTC m=+839070.944031571: ☑️ agreed by JaySon-Huang.
  • 2024-11-04 03:38:53.848907031 +0000 UTC m=+839446.688062577: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot merged commit f13226e into pingcap:release-7.1 Nov 4, 2024
4 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-bit-default-7.1 branch November 4, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lloyd-Pottiger @JaySon-Huang @CalvinNeo