Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that cloneFullColumn does not clone the subcolumns at the second and higher levels (#9606) #9607

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix the bug that cloneFullColumn does not clone the subcolumns at the second and higher levels (#9606) #9607

merged 2 commits into from
Nov 13, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 13, 2024 •
edited by JaySon-Huang
Loading

This is an automated cherry-pick of #9606

What problem does this PR solve?

Issue Number: close #9605

Problem Summary:
See #9605
The newly-added unit test will fail for the original codebase.

What is changed and how it works?

Fix the bug that `cloneFullColumn` does not clone the subcolumns at the second and higher levels

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi @ti-chi-bot
u
1b19e72 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
format
4686f99 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 13, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 13, 2024
Merged
12 tasks
gengliqi
gengliqi approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 13, 2024
@gengliqi gengliqi requested a review from windtalker November 13, 2024 02:09
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 13, 2024
windtalker
windtalker approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-13 02:09:06.686685714 +0000 UTC m=+408508.877554712: ☑️ agreed by gengliqi.
  • 2024-11-13 05:58:18.311900266 +0000 UTC m=+422260.502769256: ☑️ agreed by windtalker.

@gengliqi
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit d346b92 into pingcap:release-8.5 Nov 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@gengliqi gengliqi

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @gengliqi @windtalker