Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lpad/rpad miss trailing zero #9610

Merged
merged 6 commits into from
Nov 18, 2024
Merged

fix lpad/rpad miss trailing zero #9610

merged 6 commits into from
Nov 18, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Nov 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9465

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix lpad/rpad trailing zero miss

@guo-shaoge
fix lpad/rpad trailing zero miss
9de2e01 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Nov 13, 2024
@guo-shaoge
fix
081dc30 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix
2380749 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix
8322b96 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge guo-shaoge requested a review from yibin87 November 14, 2024 02:03
@guo-shaoge
refine
b213371 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 15, 2024
windtalker
windtalker approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 15, 2024
yibin87
yibin87 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-15 06:36:17.702186811 +0000 UTC m=+597339.893055800: ☑️ agreed by windtalker.
  • 2024-11-18 01:35:19.095983686 +0000 UTC m=+838481.286852681: ☑️ agreed by yibin87.

@guo-shaoge
Copy link
Contributor Author

/retest

1 similar comment
@guo-shaoge
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 99ab3c5 into pingcap:master Nov 18, 2024
5 checks passed
@guo-shaoge guo-shaoge added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Nov 18, 2024
@guo-shaoge guo-shaoge added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9630.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9631.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9632.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9633.

This was referenced Nov 18, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9634.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9635.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Merged
12 tasks
ti-chi-bot bot added a commit that referenced this pull request Nov 18, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix lpad/rpad trailing zero miss (#9610) (#9633)
7de7609 
close #9465

Signed-off-by: guo-shaoge <shaoge1994@163.com>

Co-authored-by: guo-shaoge <shaoge1994@163.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @guo-shaoge
fix lpad/rpad trailing zero miss (#9610) (#9635)
d183ff0 
close #9465

Signed-off-by: guo-shaoge <shaoge1994@163.com>

Co-authored-by: guo-shaoge <shaoge1994@163.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @guo-shaoge
fix lpad/rpad trailing zero miss (#9610) (#9632)
a267f14 
close #9465

Signed-off-by: guo-shaoge <shaoge1994@163.com>

Co-authored-by: guo-shaoge <shaoge1994@163.com>
@JaySon-Huang JaySon-Huang deleted the fix_pad_traling_zero branch November 20, 2024 06:28
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot @guo-shaoge
fix lpad/rpad trailing zero miss (#9610) (#9634)
99a636e 
close #9465

Signed-off-by: guo-shaoge <shaoge1994@163.com>

Co-authored-by: guo-shaoge <shaoge1994@163.com>
ti-chi-bot bot added a commit that referenced this pull request Dec 2, 2024
@ti-chi-bot @ti-chi-bot
fix lpad/rpad trailing zero miss (#9610) (#9630)
a2db730 
close #9465

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@guo-shaoge guo-shaoge changed the title fix lpad/rpad trailing zero miss fix lpad/rpad miss trailing zero Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lpad/rpad return wrong result if it need return null for not null input
4 participants
@guo-shaoge @ti-chi-bot @windtalker @yibin87