Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageCtl: Support getting blob data from PageStorage instance (release-7.5) #9717

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 11, 2024

cherry-pick of #9723

What problem does this PR solve?

Issue Number: close #9716

Problem Summary:

What is changed and how it works?

PageCtl: Support getting blob data from PageStorage instance
And output the "PageEntryV3.offset" in decimal instead of hexadecimal
>  ./dbms/src/Server/tiflash pagectl -V 3 --mode 7 --blob_id 1060 --blob_offset 30413 --blob_size 47 -P /data1/1210_down/meta
Running with mode=DISPLAY_BLOB_DATA
...
checksum: 0xE1CB85684ED5E5B6
hex:030000000500000000000000220A18080010011A08800000000003D05C2208800000000007A11510F04418F744201A

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2024
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 11, 2024
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-11 08:12:19.015379007 +0000 UTC m=+426129.104181542: ☑️ agreed by JinheLin.
  • 2024-12-11 08:20:48.23349379 +0000 UTC m=+426638.322296333: ☑️ agreed by CalvinNeo.

@JaySon-Huang JaySon-Huang changed the title PageCtl: Support getting blob data from PageStorage instance PageCtl: Support getting blob data from PageStorage instance (release-7.5) Dec 11, 2024
@JaySon-Huang
Copy link
Contributor Author

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 3cad810 into pingcap:release-7.5 Dec 11, 2024
4 checks passed
@JaySon-Huang JaySon-Huang deleted the enhance_page_ctl_75 branch December 12, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants