Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the local clock dependency from storage sink #10352

Closed
CharlesCheung96 opened this issue Dec 23, 2023 · 0 comments · Fixed by #10351
Closed

remove the local clock dependency from storage sink #10352

CharlesCheung96 opened this issue Dec 23, 2023 · 0 comments · Fixed by #10351
Assignees
@CharlesCheung96
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.

Comments

@CharlesCheung96
Copy link
Contributor

Currently, the cloud storage sink uses local clock to generate files. If A table is scheduled from cdc node A to cdc node B, and ntp is not enabled on the cluster, or the time of the two machines is different, the generated file names may be backward or not incremental.
@CharlesCheung96 CharlesCheung96 mentioned this issue Dec 23, 2023
Merged
@CharlesCheung96 CharlesCheung96 added type/enhancement The issue or PR belongs to an enhancement. area/ticdc Issues or PRs related to TiCDC. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Jan 10, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jan 22, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (#10351)
c8ea7d0 
close #10352, ref #10374
This was referenced Jan 22, 2024
Merged
Merged
Merged
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
cff9687 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
89b4b6a 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
88b5469 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
525bb49 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Feb 7, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
450c156 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Feb 9, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
ca81e65 
close pingcap#10352, ref pingcap#10374
ti-chi-bot bot pushed a commit that referenced this issue Feb 9, 2024
@ti-chi-bot
sink(ticdc): use pd clock in storage sink (#10351) (#10521)
67111b1 
close #10352, ref #10374
ti-chi-bot bot pushed a commit that referenced this issue Feb 26, 2024
@ti-chi-bot
sink(ticdc): use pd clock in storage sink (#10351) (#10520)
223283c 
close #10352, ref #10374
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@ti-chi-bot
sink(ticdc): use pd clock in storage sink (#10351) (#10519)
39759ab 
close #10352, ref #10374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharlesCheung96 CharlesCheung96

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sink(ticdc): use pd clock in storage sink CharlesCheung96/tiflow
1 participant
@CharlesCheung96