Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo log: storage permission pre-check is need #6335

Closed
Tammyxia opened this issue Jul 18, 2022 · 4 comments · Fixed by #7993
Closed

redo log: storage permission pre-check is need #6335

Tammyxia opened this issue Jul 18, 2022 · 4 comments · Fixed by #7993
Assignees
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@Tammyxia
Copy link

What did you do?

  • When create changefeed with redo log storage config like this:
    [consistent]
    level = "eventual"
    max-log-size = 1
    storage = "nfs:///mnt/nfs/var/nfs"

  • But some cdc server have not this directory "/mnt/nfs/var/nfs", the behavior right now is : create changefeed can be successful, but later storage persimission deny: "[CDC:ErrRedoFileOp]redo file operation: open /mnt/nfs/var/nfs/172.16.6.46:8420_mysql-test1_meta.meta.mtmp: permission denied"

  • It's better if storage directory/permission is pre-checked before successfully creating changefeed.

What did you expect to see?

No response

What did you see instead?

As above

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
v6.2.0 nightly
@Tammyxia Tammyxia added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Jul 18, 2022
@Tammyxia
Copy link
Author

storage config also has not pre-check, for example,
{
"id": "redo-apply-cdc-all-node-restart-sync",
"namespace": "default",
"summary": {
"state": "error",
"tso": 434713341392060417,
"checkpoint": "2022-07-20 06:49:54.739",
"error": {
"addr": "upstream-ticdc-0.upstream-ticdc-peer.cdc-testbedcl8xv.svc:8301",
"code": "CDC:ErrOwnerUnknown",
"message": "parse "s3://nfs/test-infra-redolog/redo-apply-cdc-all-node-restart-sync-%!s(func(int64, int64) time.Time=0x1023964a0)-2022-07-20 14:49:51.202209 %2B0800 CST m=%2B0.069564334?access-key=minioadmin\u0026secret-access-key=minioadmin\u0026endpoint=http://minio.pingcap.net:9000\u0026force-path-style=true\": invalid URL escape "%!s""
}

@nongfushanquan
Copy link
Contributor

/assign @asddongmen

@nongfushanquan
Copy link
Contributor

/label affects-6.1

@ti-chi-bot ti-chi-bot added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Jan 4, 2023
@nongfushanquan
Copy link
Contributor

/label affects-6.5

@ti-chi-bot ti-chi-bot added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Jan 4, 2023
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 4, 2023
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 4, 2023
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 4, 2023
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants