Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race of Start/Close of DM-worker's Server #6401

Closed
lance6716 opened this issue Jul 21, 2022 · 5 comments · Fixed by #7057
Closed

data race of Start/Close of DM-worker's Server #6401

lance6716 opened this issue Jul 21, 2022 · 5 comments · Fixed by #7057
Labels
area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

What did you do?


[2022-07-21T02:26:46.380Z] WARNING: DATA RACE

[2022-07-21T02:26:46.380Z] Write at 0x00c000888810 by goroutine 94:

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/dm/worker.(*Server).Start.func1()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/worker/server.go:130 +0x6ee

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/dm/worker.(*Server).Start()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/worker/server.go:241 +0xa4

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/cmd/dm-worker.main()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/cmd/dm-worker/main.go:93 +0x944

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/cmd/dm-worker.TestRunMain.func3()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/cmd/dm-worker/main_test.go:66 +0x2b

[2022-07-21T02:26:46.380Z] 

[2022-07-21T02:26:46.380Z] Previous read at 0x00c000888810 by goroutine 104:

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/dm/worker.(*Server).Close()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/worker/server.go:496 +0x64

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/cmd/dm-worker.main.func2()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/cmd/dm-worker/main.go:91 +0x1b7

[2022-07-21T02:26:46.380Z] 

[2022-07-21T02:26:46.380Z] Goroutine 94 (running) created at:

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/cmd/dm-worker.TestRunMain()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/cmd/dm-worker/main_test.go:65 +0x331

[2022-07-21T02:26:46.380Z]   testing.tRunner()

[2022-07-21T02:26:46.380Z]       /usr/local/go/src/testing/testing.go:1439 +0x213

[2022-07-21T02:26:46.380Z]   testing.(*T).Run.func1()

[2022-07-21T02:26:46.380Z]       /usr/local/go/src/testing/testing.go:1486 +0x47

[2022-07-21T02:26:46.380Z] 

[2022-07-21T02:26:46.380Z] Goroutine 104 (finished) created at:

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/cmd/dm-worker.main()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/cmd/dm-worker/main.go:88 +0x938

[2022-07-21T02:26:46.380Z]   github.com/pingcap/tiflow/cmd/dm-worker.TestRunMain.func3()

[2022-07-21T02:26:46.380Z]       /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/cmd/dm-worker/main_test.go:66 +0x2b

[2022-07-21T02:26:46.380Z] ==================

What did you expect to see?

No response

What did you see instead?

No response

Versions of the cluster

master

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@lance6716 lance6716 added type/bug The issue is confirmed as a bug. area/dm Issues or PRs related to DM. severity/minor labels Jul 21, 2022
@D3Hunter
Copy link
Contributor

/assign @liumengya94

@ti-chi-bot
Copy link
Member

@D3Hunter: GitHub didn't allow me to assign the following users: liumengya94.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @liumengya94

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@niubell
Copy link
Contributor

niubell commented Sep 5, 2022

/assign liumengya94

@niubell
Copy link
Contributor

niubell commented Sep 5, 2022

/assign @liumengya94

@ti-chi-bot
Copy link
Member

@niubell: GitHub didn't allow me to assign the following users: liumengya94.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @liumengya94

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants