Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDC "/status" API may cause panic #6838

Closed
overvenus opened this issue Aug 22, 2022 · 3 comments
Closed

CDC "/status" API may cause panic #6838

overvenus opened this issue Aug 22, 2022 · 3 comments
Assignees
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. component/api HTTP API. severity/major type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

What did you do?

│[2022/08/16 18:35:57.674 +05:30] [INFO] [version.go:47] ["Welcome to Change Data Capture (CDC)"] [release-version=v6.1.0-20220812] [git-hash=b3cd5a49c75ceca1faeae6f6f9f3a1c03fb071eb] [git-branch=heads/refs/tags/v6.1.0-20220812] [utc-build-time="2022-08-12 11:56:07"] [go│
│[2022/08/16 18:35:57.674 +05:30] [INFO] [server.go:78] ["creating CDC server"] [pd="[http://lockin-cm-ch-pd:2379]"] [config="{\"addr\":\"0.0.0.0:8301\",\"advertise-addr\":\"lockin-cm-ch-ticdc-3.lockin-cm-ch-ticdc-peer.rigel-clusters-prod.svc:8301\",\"log-file\":\"/dev/s│
│[2022/08/16 18:35:58.411 +05:30] [INFO] [server.go:320] ["/ticdc/data is set as data-dir (62GB available), sort-dir=/ticdc/data/tmp/sorter. It is recommended that the disk for data-dir at least have 500GB available space"]                                                │
│[2022/08/16 18:35:58.412 +05:30] [INFO] [server.go:199] ["http server is running"] [addr=0.0.0.0:8301]                                                                                                                                                                        │
│2022/08/16 18:35:58 http: panic serving 10.39.136.210:51186: runtime error: invalid memory address or nil pointer dereference                                                                                                                                                 │
│goroutine 224 [running]:                                                                                                                                                                                                                                                      │
│net/http.(*conn).serve.func1()                                                                                                                                                                                                                                                │
│       net/http/server.go:1825 +0xbf                                                                                                                                                                                                                                          │
│panic({0x2dcea20, 0x647e000})                                                                                                                                                                                                                                                 │
│       runtime/panic.go:844 +0x258                                                                                                                                                                                                                                            │
│github.com/pingcap/tiflow/cdc/capture.(*Capture).Info(0x27?)                                                                                                                                                                                                                  │
│       github.com/pingcap/tiflow/cdc/capture/capture.go:321 +0x8c                                                                                                                                                                                                             │
│github.com/pingcap/tiflow/cdc/api.(*statusAPI).handleStatus(0xc000944848, {0x7fc681959868, 0xc000d16100}, 0xc000b82000?)                                                                                                                                                      │
│       github.com/pingcap/tiflow/cdc/api/status.go:77 +0xf0                                                                                                                                                                                                                   │
│github.com/gin-gonic/gin.WrapF.func1(0xc000d16100)                                                                                                                                                                                                                            │
│       github.com/gin-gonic/gin@v1.7.4/utils.go:41 +0x59                                                                                                                                                                                                                      │
│github.com/gin-gonic/gin.(*Context).Next(...)                                                                                                                                                                                                                                 │
│       github.com/gin-gonic/gin@v1.7.4/context.go:165                                                                                                                                                                                                                         │
│github.com/gin-gonic/gin.(*Engine).handleHTTPRequest(0xc0002c0340, 0xc000d16100)                                                                                                                                                                                              │
│       github.com/gin-gonic/gin@v1.7.4/gin.go:489 +0x63e                                                                                                                                                                                                                      │
│github.com/gin-gonic/gin.(*Engine).ServeHTTP(0xc0002c0340, {0x3a2d840?, 0xc0006600e0}, 0xc000d16000)                                                                                                                                                                          │
│       github.com/gin-gonic/gin@v1.7.4/gin.go:445 +0x1c5                                                                                                                                                                                                                      │
│net/http.serverHandler.ServeHTTP({0xc000592180?}, {0x3a2d840, 0xc0006600e0}, 0xc000d16000)                                                                                                                                                                                    │
│       net/http/server.go:2916 +0x43b                                                                                                                                                                                                                                         │
│net/http.(*conn).serve(0xc000a640a0, {0x3a2f530, 0xc00055c570})                                                                                                                                                                                                               │
│       net/http/server.go:1966 +0x5d7                                                                                                                                                                                                                                         │
│created by net/http.(*Server).Serve                                                                                                                                                                                                                                           │
│       net/http/server.go:3071 +0x4db                                                                                                                                                                                                                                         │

What did you expect to see?

No panic.

What did you see instead?

Panic.

Versions of the cluster

TiCDC version (execute cdc version):

v6.1.0
@overvenus overvenus added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. component/api HTTP API. labels Aug 22, 2022
@fubinzh
Copy link

fubinzh commented Aug 23, 2022

/severity Major

@asddongmen asddongmen added affects-5.0 affects-4.0 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. labels Aug 23, 2022
@nongfushanquan
Copy link
Contributor

/close

@ti-chi-bot
Copy link
Member

@nongfushanquan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. component/api HTTP API. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

5 participants